Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exterminator scenario #2126

Merged
merged 3 commits into from
Nov 2, 2024
Merged

exterminator scenario #2126

merged 3 commits into from
Nov 2, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Aug 18, 2024 •
edited
Loading 

scripts/play.sh --scenario data/scenarios/Challenges/Ranching/pied-piper.yaml --autoplay

In addition to the scenario, this PR:

  1. Adds support for colorizing robot names
  2. Improves diagnostic message for subworld portal spatial consistency enforcement

@kostmo kostmo force-pushed the scenario/pied-piper branch 2 times, most recently from 7b1dcae to d458be5 Compare August 25, 2024 18:10
@kostmo kostmo changed the title [WIP] new scenario exterminator scenario Oct 19, 2024
@kostmo kostmo force-pushed the scenario/pied-piper branch 3 times, most recently from a5fc69a to 7eec7ea Compare October 19, 2024 20:32
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Closed
@kostmo kostmo force-pushed the scenario/pied-piper branch 2 times, most recently from 3d2dab2 to fe98508 Compare October 21, 2024 04:09
@kostmo kostmo force-pushed the scenario/pied-piper branch 3 times, most recently from ba453be to 3a91541 Compare November 2, 2024 18:48
@kostmo kostmo marked this pull request as ready for review November 2, 2024 18:54
@kostmo kostmo requested review from xsebek and byorgey November 2, 2024 18:54
byorgey
byorgey approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I love watching the "intended" solution which leads all the rats into the silo cellar and then kills them with mold. However, I solved it in a much simpler way: after obtaining some mold, I grew a bunch in the silo and harvested it. Then, I went to each door and placed a single mold right outside the door, and a single oats behind the mold. Just as I hoped, the rats were attracted to the oats but died as soon as they exited the door and walked on the mold. I don't particularly care --- I think the scenario is fun as it is --- but I'll leave it up to you whether you want to disallow such "unintended" solutions.

@kostmo
Copy link
Member Author

kostmo commented Nov 2, 2024

I went to each door and placed a single mold right outside the door

Good find. I believe I've closed this loophole now.

@byorgey
Copy link
Member

byorgey commented Nov 2, 2024

I believe I've closed this loophole now.

Yes, it seems to work as intended now!

@kostmo kostmo added merge me Trigger the merge process of the Pull request. and removed merge me Trigger the merge process of the Pull request. labels Nov 2, 2024
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Nov 2, 2024
@mergify mergify bot merged commit ca229ee into main Nov 2, 2024
14 checks passed
@mergify mergify bot deleted the scenario/pied-piper branch November 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey